Re: [PATCH v2 0/5] leds: trigger: Add pattern initialization from Device Tree

From: Jacek Anaszewski
Date: Mon Dec 10 2018 - 16:03:30 EST

Hi Krzysztof,

Thank you for the update.

On 12/10/18 10:29 AM, Krzysztof Kozlowski wrote:

I rebased on top of Jacek's patches and, as I could not find them on git kernel
tree, I included them here. Also with small fixup.

Changes since v1:
1. Rebase on Jacek's patches.

Made following amendments to 2/5:

- removed extra empty line
- fixed language in the commit message as proposed by Pavel

2. Add patch 3/5 for fixup of Jacek's solution.
3. Drop first two patches from the series (applied).
4. Patch 5/5: Use LED_INIT_DEFAULT_TRIGGER (suggested by Jacek Anaszewski).
5. Patch 5/5: Return-on-error and log warning (suggested by Pavel Machek)
Applied to the for-next branch of linux-leds.git, thanks.

Pavel - I'm still awaiting your acks, just wanted to have
the patch set in linux-next quicker, taking into account that
merge window is imminent.

Best regards,
Jacek Anaszewski

Jacek Anaszewski (2):
led: triggers: Break the for loop after default trigger is found
led: triggers: Add LED_INIT_DEFAULT_TRIGGER flag

Krzysztof Kozlowski (3):
led: triggers: Initialize LED_INIT_DEFAULT_TRIGGER if trigger is
brought after class
dt-bindings: leds: Add pattern initialization from Device Tree
leds: trigger: Add pattern initialization from Device Tree

Documentation/devicetree/bindings/leds/common.txt | 7 +++++
drivers/leds/led-triggers.c | 10 +++++--
drivers/leds/trigger/ledtrig-pattern.c | 32 +++++++++++++++++++++++
include/linux/leds.h | 1 +
4 files changed, 48 insertions(+), 2 deletions(-)