Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option

From: Nathan Chancellor
Date: Mon Dec 10 2018 - 19:25:34 EST


On Tue, Dec 11, 2018 at 10:46:26AM +1030, Joel Stanley wrote:
> On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> >
> >
> >
> > On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > > Clang does not support this option:
> > >
> > > warning: unknown warning option '-Woverride-init'; did you mean
> > > '-Woverride-module'? [-Wunknown-warning-option]
> > > 1 warning generated.
> > >
> > > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> >
> > Acked-by: Andrew Jeffery <andrew@xxxxxxxx>
>
> Thanks Nathan.
>
> Andrew explained to me that this warning helps find bugs when
> developing the complicated (some would say crazy) set of macros that
> this pinctrl driver uses. It would be good to have this warning
> available in clang. Do we have a clang issue opened for that?
>
> Acked-by: Joel Stanley <joel@xxxxxxxxx>
>
> Cheers,
>
> Joel

Hi Joel,

I just opened https://github.com/ClangBuiltLinux/linux/issues/293.

I searched the LLVM issue tracker and haven't see any reference of this.
I can file an issue but if you are a little more familiar with this
warning, you are welcome to do it instead.

Thanks for the quick response,
Nathan