RE: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

[Anson Huang]

Hi, Rob

Best Regards!
Anson Huang

> -----Original Message-----
> From: Rob Herring [mailto:robh@xxxxxxxxxx]
> Sent: 2018年12月11日 7:24
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: jic23@xxxxxxxxxx; knaack.h@xxxxxx; lars@xxxxxxxxxx;
> pmeerw@xxxxxxxxxx; mark.rutland@xxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
> supply name
> 
> On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote:
> > According to datasheet, the isl29018 has "vddd/vdda" power supply, and
> > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply
> > name with "vdd" and "vdda" according to datasheet to cover all devices
> > and avoid confusion.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > index b9bbde3..36f737d 100644
> > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > @@ -15,7 +15,9 @@ Optional properties:
> >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> >    node bindings.
> >
> > -  - vcc-supply: phandle to the regulator that provides power to the sensor.
> > +  - vdd-supply: phandle to the regulator that provides vdd power to the
> sensor.
> > +
> > +  - vdda-supply: phandle to the regulator that provides vdda power to the
> sensor.
> 
> Is this in use? You can't just change things if it is.

I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all,
so I take this chance to update it according to datasheet. Thanks.

Anson


> 
> Rob