Re: [PATCH v2 1/6] misc: dt-bindings: Add Qualcomm Fastrpc bindings

From: Srinivas Kandagatla
Date: Tue Dec 11 2018 - 04:27:08 EST

On 11/12/18 00:10, Bjorn Andersson wrote:
+- reg
+ Usage: required
+ Value type: <u32>
+ Definition: DSP Processor ID.
+ Possible values are :
+ 0 - ADSP
+ 1 - MDSP
+ 2 - SDSP
+ 3 - CDSP
Why is this in a reg?
This is to identify which type of dsp(Audio/Modem/Sensor/Compute) it is,
This information is used to create device nodes for user-space access.

But it does not represent FastRPC's address on the rpmsg bus. How about
replacing it with a "label" (or "qcom,domain" perhaps?) of type string?

Yes, we could replace reg with label in this case. I don't have any particular preference TBH.

I did try to something similar to "qcom,domain" for apr and Rob H suggested to use reg instead during review!