Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver
From: Taniya Das
Date: Tue Dec 11 2018 - 08:35:55 EST
Sorry for the delayed response. Thanks for the patch.
On 12/5/2018 11:46 AM, Viresh Kumar wrote:
On 05-12-18, 09:07, Taniya Das wrote:
Hello Stephen, Viresh
Thanks for the code and suggestions.
Having a NR_DOMAINS '2' makes the driver not scalable for re-use.
Sure, I didn't like it either and that wasn't really what I was suggesting in
the first place. I didn't wanted to write the code myself and pass it on, but I
have it now anyway :)
It may have a bug or two in there, but compiles just fine and is rebased over
your patch Taniya.
The design here assumes that there would not be any per-cpu/per-cluster
based SW requirement for the HW during frequency transitions, which
again makes me think that we would require to re-introduce these
structures again in case we have such requirements in near future.
Also I think leaving the structures also helps us debug any boot up
issues looking at the ram contents of the per-(cpu/cluster) structures
with the contents from the firmware.
Hope these above helps us to go ahead with the current SW design.
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.