Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

From: Jean Delvare
Date: Tue Dec 11 2018 - 08:49:57 EST

On Tue, 2018-12-11 at 13:06 +0100, Peter Korsgaard wrote:
> > > > > > "Peter" == Peter Korsgaard <peter@xxxxxxxxxxxxx> writes:
> Hi Jean,
> >> Look, you can imagine that I was perfectly aware of what I was doing
> >> when I made that change, and that I pondered the decision carefully at
> >> that time. And my decision was that the change should be made. As far
> >> as I'm concerned, this ship has sailed already, sorry.
> > Sorry, what is the perceived risk of reverting this change? Just the
> > minor inconsistency between the dmidecode and sysfs output? As stated
> > above, the RFC requires conforming parsers to handle upper case as well.
> I would appreciate if you could explain what risk you see from reverting
> this change?

The exact same risk that you are complaining about, for a different
pair of kernel versions. You cannot at the same time argue that the
change should not have been done back then, and ask for same change to
be done again now.

Jean Delvare
SUSE L3 Support