Re: [PATCH] printk: Add caller information to printk() output.

[Sergey Senozhatsky]

On (12/12/18 11:25), Sergey Senozhatsky wrote:
> On (12/11/18 19:26), Tetsuo Handa wrote:
> > @@ -688,12 +701,21 @@ static ssize_t msg_print_ext_header(char *buf, size_t size,
> >  				    struct printk_log *msg, u64 seq)
> >  {
> >  	u64 ts_usec = msg->ts_nsec;
> > +	char from[18];
> 
> [..]
> 
> > +#ifdef CONFIG_PRINTK_FROM
> > +static size_t print_from(u32 id, char *buf)
> > +{
> > +	char from[12];
> 
> Are those supposed to be of different sizes: 18 and 12?

Yeah, they are. strlen(",from="). Sorry for the noise.

The patch looks good to me.

	-ss