Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
From: Firoz Khan
Date: Tue Dec 11 2018 - 23:35:24 EST
On Wed, 12 Dec 2018 at 00:29, Paul Burton <paul.burton@xxxxxxxx> wrote:
> > Will this below change will help?
> > #define _MIPS_SIM_ABI32 1
> > #define _MIPS_SIM_NABI32 2
> > #define _MIPS_SIM_ABI64 3
> > +#define _MIPS_SIM_ABIN64 _MIPS_SIM_ABI64
> Hmm, I think I'd prefer that we just keep using _MIPS_SIM_ABI64.
Sure, I think '64' to 'n64' conversion must be remove it from this patch
series.I can send v5 without '64' to 'n64' conversion.
If we rename '64' to 'n64' in half of the place and this _MIPS_SIM_ABI64
if we half to keep it in same looks not good (according to me).
(FYI, This macro name - _MIPS_SIM_ABIN64 must be _MIPS_SIM_NABI64
and defintion will be:
+#define _MIPS_SIM_NABI64 _MIPS_SIM_ABI64)
So If you confirm I can send v5 without '64' to 'n64' conversion (not just above
one, completely from this patch series). Or uou can take a call just
keep this macro -
_MIPS_SIM_ABI64 as it is and change it rest of the place.