Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

From: Ashish Mhetre
Date: Wed Dec 12 2018 - 02:45:28 EST

On 12/12/18 12:19 PM, Sagi Grimberg wrote:

 struct nvme_sgl_desc {
ÂÂÂÂÂ __le64ÂÂÂ addr;
-ÂÂÂ __le32ÂÂÂ length;
+ÂÂÂ __le64ÂÂÂ length;
ÂÂÂÂÂ __u8ÂÂÂ rsvd[3];
ÂÂÂÂÂ __u8ÂÂÂ type;

Isn't this a device or protocol defined datastructure? You can't just
change it like this.

You're correct, we can't...
[Replied before seeing this issue was already highlighted]

The positive side is that it can safely be removed without affecting the
rest of the patch...

Ohh, I am not aware of this protocol defined data-structures. But it seems that this need not be changed as Sagi is saying sg length for NVME
will never cross 32 bit size.
I'll send a new version removing this change. Thanks.