Re: [PATCH 02/11] staging: iio: adt7316: invert the logic of the check for an ldac pin

From: Dan Carpenter
Date: Wed Dec 12 2018 - 03:20:32 EST


On Tue, Dec 11, 2018 at 05:54:54PM -0700, Jeremy Fertic wrote:
> ADT7316_DA_EN_VIA_DAC_LDCA is set when the dac and ldac registers are being
> used to update the dacs instead of the ldac pin. ADT7516_SEL_AIN3 is an adc
> input that shares the ldac pin. Only set these bits if an ldac pin is not
> being used.
>
> Signed-off-by: Jeremy Fertic <jeremyfertic@xxxxxxxxx>

Huh... This bug has always been there...

Fixes: 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9 driver")

regards,
dan carpenter