Re: [PATCH v2 0/3] ARM: dts: meson: add the APB/APB2 busses
From: Neil Armstrong
Date: Wed Dec 12 2018 - 04:52:39 EST
On 11/12/2018 23:09, Martin Blumenstingl wrote:
> Hi Neil,
> On Tue, Dec 11, 2018 at 10:16 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>> On 08/12/2018 17:50, Martin Blumenstingl wrote:
>>> This adds the APB bus on Meson8 and Meson8b as well as the APB2 bus on
>>> Meson6. This is preparation work for adding the Mali GPU which is
>>> located on theses busses.
>>> Meson6 seems to have it's APB at 0xc8000000 instead of 0xd0000000. The
>>> region at 0xd0000000 is called APB2 or A9_APB and it has a different
>>> size (256k) compared to Meson8 and Meson8b (2M).
>>> Addresses and sizes are taken from the Amlogic 3.10 kernel sources:
>>> - Meson6: 
>>> - Meson8: 
>>> - Meson8b: 
>>> Changes since v1 at :
>>> - re-send the patches but this time don't include the old patches
>>> which still had a typo in the patch description (ABP vs APB)
>>>  https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson6/include/mach/io.h#L61
>>>  https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8/include/mach/io.h#L53
>>>  https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8b/include/mach/io.h#L53
>>>  http://lists.infradead.org/pipermail/linux-amlogic/2018-December/009424.html
>>> Martin Blumenstingl (3):
>>> ARM: dts: meson6: add the APB2 bus
>>> ARM: dts: meson8: add the APB bus
>>> ARM: dts: meson8b: add the APB bus
>>> arch/arm/boot/dts/meson6.dtsi | 8 ++++++++
>>> arch/arm/boot/dts/meson8.dtsi | 8 ++++++++
>>> arch/arm/boot/dts/meson8b.dtsi | 8 ++++++++
>>> 3 files changed, 24 insertions(+)
>> Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> thank you for taking the time to review this!
>> But frankly I'll squash the meson8/meson8b patches with the mali node patches !
> I didn't do this because I realized that there are different busses
> between Meson6 and Meson8/Meson8b. so I wanted to have a commit
> message which describes this.
> if you prefer I can still squash the Meson8 and Meson8b patches into
> their corresponding GPU .dts patch but I would like to keep the Meson6
> patch (as I'm not planning to add the Mali GPU until someone can
> actually test it on that SoC)
Yes this is what I was thinking actually !