Re: [PATCH 3/3] pwm: imx: Implement get_state() function for hardware readout

From: Thierry Reding
Date: Wed Dec 12 2018 - 05:54:39 EST


On Mon, Oct 01, 2018 at 04:19:48PM +0200, Michal VokÃÄ wrote:
> Implement the get_state() function and set the initial state to reflect
> real state of the hardware. This allows to keep the PWM running if it was
> enabled in bootloader. It is very similar to the GPIO behavior. GPIO pin
> set as output in bootloader keep the same setting in Linux unless it is
> reconfigured.
>
> If we find the PWM block enabled we need to prepare and enable its source
> clock otherwise the clock will be disabled late in the boot as unused.
> That will leave the PWM in enabled state but with disabled clock. That has
> a side effect that the PWM output is left at its current level at which
> the clock was disabled. It is totally non-deterministic and it may be LOW
> or HIGH.
>
> Signed-off-by: Michal VokÃÄ <michal.vokac@xxxxxxxxx>
> ---
> drivers/pwm/pwm-imx.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature