Re: [PATCH v2 6/6] misc: fastrpc: Add support for compat ioctls

From: Greg KH
Date: Wed Dec 12 2018 - 05:59:38 EST

On Fri, Dec 07, 2018 at 04:35:13PM +0000, Srinivas Kandagatla wrote:
> This patch adds support for compat ioctl from 32 bits userland to
> Qualcomm fastrpc driver.

Ick, why?

Why not just fix up your ioctl structures to not need that at all? For
new code being added to the kernel, there's no excuse to have to have
compat structures anymore, just make your api sane and all should be

What prevents you from doing that and requiring compat support?


greg k-h