Re: [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method

From: Greg KH
Date: Wed Dec 12 2018 - 06:02:40 EST

On Fri, Dec 07, 2018 at 04:35:10PM +0000, Srinivas Kandagatla wrote:
> +#define FASTRPC_BUILD_SCALARS(attr, method, in, out, oin, oout) \
> + ((((uint32_t) (attr) & 0x07) << 29) | \
> + (((uint32_t) (method) & 0x1f) << 24) | \

Why all of the uint32_t and uint64_t types in this patch, but not the
previous one?

Please just stick with u32 and u64, those are the correct kernel types
to be using everywhere. uint32_t and friends are userspace things that
make no sense in kernel space.

Yes, I know people use them, but we should not be adding to the problem
by creating new instances of them for no good reason.


greg k-h