Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

[Anson Huang]

Hi, Fabio

From Anson's iPhone 6

> 
> We should not break existing dtbs, so in this case just keep the
> existing supply name and you could add the new optional vdda supply as
> per the datasheet.

        Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name âVDDâ in datasheet for regulator name?

Anson.