Re: [PATCH 08/17] soc: ti: pruss: Add a PRUSS irqchip driver for PRUSS interrupts

From: Roger Quadros
Date: Wed Dec 12 2018 - 10:48:20 EST


Tony,

On 26/11/18 21:33, Tony Lindgren wrote:
> * Roger Quadros <rogerq@xxxxxx> [181126 08:09]:
>> Tony,
>>
>> On 23/11/18 18:37, Tony Lindgren wrote:
>>> * Roger Quadros <rogerq@xxxxxx> [181122 11:39]:
>>>> The PRUSS INTC module is reference counted during the interrupt
>>>> setup phase through the irqchip's irq_request_resources() and
>>>> irq_release_resources() ops. This restricts the module from being
>>>> removed as long as there are active interrupt users.
>>>
>>> So are there any reasons why this could not be just a regular
>>> drivers/irqchip driver nowadays?
>>
>> This is a reqular irqchip driver. Do you mean it should be moved
>> to drivers/irqchip directory?
>
> I think so, is there something preventing doing it?
>
No.

> Also, is this maybe the same INTC that we already have a
> driver for in drivers/irqchip/irq-omap-intc.c?

No, it is completely different.

cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki