Re: linux-next: Signed-off-by missing for commits in the bpf-next tree
From: Alexei Starovoitov
Date: Wed Dec 12 2018 - 23:36:00 EST
On Wed, Dec 12, 2018 at 04:45:26PM -0800, David Miller wrote:
> From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
> Date: Wed, 12 Dec 2018 15:39:10 -0800
> > But this approach doesn't scale.
> > We do rebase our trees when we need to fixup or drop patches and
> > at any given point a number of commits will be committed by me
> > and another set by Daniel. When we rebase we cannot keep adding
> > our SOBs to the other person SOBs.
> > Then comes the next rebase and we get to the point of
> > double and triple SOBs ?
> If you use "--signoff" in whatever commands do the rebase you will
> get exactly one signoff for yourself and Daniel at maximum. If it
> is there already, git will not add a duplicate one on top.
If Stephen's scripts can recognize SOB anywhere in the log then
--signoff can theoretically solve it.
Unfortunately it's "Incompatible with the --interactive option"
So we have to do things manually
or fix scripts
or fix git.