Re: [PATCH v4 0/5] add PM functionality for act8945a PMIC

From: Claudiu.Beznea
Date: Thu Dec 13 2018 - 07:59:07 EST


Hi Mark,

I saw that previous version of this series was applied to your tree just
after I've send this new one. The only difference b/w them is in the
documentation patch where I moved the new header. No functionality change.

Sorry for the noise,
Claudiu Beznea

On 13.12.2018 14:49, Claudiu Beznea - M18063 wrote:
> From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>
> This series implements PM functionality for act8945a PMIC and use that support
> on SAMA5D2 Xplained board.
>
> Changes in v4:
> - move dt-bindings/regulator/active-semi,8945a-regulator.h in documentation
> patch; driver uses macros included in this file; due to this documentation
> patch and drivers patches should go through the same tree
> - make documentation patch, patch 2 of this series
>
> Changes in v3:
> - add patch "unlock expert registers"; it was wrongly missed in previous version
>
> Changes in v2:
> - split patch 1/1 from previous series in 3 patches: one adding regmap,
> one adding pm functionality, one adding shutdown functionality
> - use dev_pm_ops suspend function to set register specific to PWRHLD line: this
> is specific to PMIC itself and not to regulators
> - add mode support for LDOs
> - add constants for mode in dt-bindings/regulator/active-semi,8945a-regulator.h
> - document modes and regulator suspend states
> - remove rdevs from struct act8945a_pmic since were not used anywhere
> - add op_mode field in struct act8945a_pmic, update it when setting mode and
> return it when reading mode (avoiding one extra register read while
> reading mode)
> - add a patch to fix a checkpatch.pl warning
> - in shutdown function use directly act8945a->regmap instead of an intermediary
> struct regmap variable
>
> Boris Brezillon (2):
> regulator: act8945a-regulator: Implement PM functionalities
> ARM: dts: at91: sama5d2_xplained: Add proper regulator states for
> suspend-to-mem
>
> Claudiu Beznea (3):
> regulator: act8945a-regulator: fix line over 80 chars warning
> regulator: act8945a-regulator: add shutdown function
> regulator: add documentation for regulator modes and suspend states
>
> .../bindings/regulator/act8945a-regulator.txt | 34 ++++
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 54 ++++++
> drivers/regulator/act8945a-regulator.c | 200 ++++++++++++++++++++-
> .../regulator/active-semi,8945a-regulator.h | 30 ++++
> 4 files changed, 312 insertions(+), 6 deletions(-)
> create mode 100644 include/dt-bindings/regulator/active-semi,8945a-regulator.h
>