Re: [PATCH 01/11] staging: iio: adc: ad7606: Simplify the Kconfing menu
From: Rob Herring
Date: Thu Dec 13 2018 - 10:38:12 EST
On Thu, Dec 13, 2018 at 8:18 AM Stefan Popa <stefan.popa@xxxxxxxxxx> wrote:
> There is no point in having three menu entries that can be selected
> individually. Instead, the SPI and parallel interfaces should select
> Signed-off-by: Stefan Popa <stefan.popa@xxxxxxxxxx>
> drivers/staging/iio/adc/Kconfig | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index fc23059..af1bad8 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -4,35 +4,29 @@
> menu "Analog to digital converters"
> config AD7606
> - tristate "Analog Devices AD7606 ADC driver"
> + tristate
> depends on GPIOLIB || COMPILE_TEST
> depends on HAS_IOMEM
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> - help
> - Say yes here to build support for Analog Devices:
> - ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
> - To compile this driver as a module, choose M here: the
> - module will be called ad7606.
> config AD7606_IFACE_PARALLEL
> - tristate "parallel interface support"
> - depends on AD7606
> + tristate "Analog Devices AD7606 ADC driver with parallel interface support"
> + select AD7606
I don't think this works because the depends on for AD7606 may not be
satisfied. Moving the HAS_IOMEM here would help and either drop
GPIOLIB or move that too.