Re: [PATCH 6/6] Drop flex_arrays

[Matthew Wilcox]

On Thu, Dec 13, 2018 at 10:51:49AM -0500, Neil Horman wrote:
> On Thu, Dec 13, 2018 at 06:41:11AM -0800, Matthew Wilcox wrote:
> > On Thu, Dec 13, 2018 at 09:30:47PM +0900, Xin Long wrote:
> > > On Sat, Sep 8, 2018 at 1:57 AM Kent Overstreet
> > > <kent.overstreet@xxxxxxxxx> wrote:
> > > >
> > > > All existing users have been converted to generic radix trees
> > > NAK, SCTP is still using flex_arrays,
> > > # grep flex_array net/sctp/*
> > > 
> > > This patch will break the build.
> > 
> > sctp added that user after this patch was sent.  Please stop adding
> > flexarray users!
> > 
> > This particular user should probably have just used kvmalloc.
> > 
> 
> No, I don't think thats right.
> 
> This appears to have been sent on September 7th.  Commit
> 0d493b4d0be352b5e361e4fa0bc3efe952d8b10e, which added the use of flex_arrays to
> sctp, seems to have been merged on August 10th, a month prior.

Are you seriously suggesting anybody sending cleanups needs to be
monitoring every single email list to see if anybody has added a new user?
Removing the flexarray has been advertised since May.
https://lkml.org/lkml/2018/5/22/1142

> regardless, however, sctp has a current in-tree use of flex_arrays, and merging
> this patch will break the build without a respin.

Great.  I await your patch to replace the flexarray usage.