Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

From: Sasha Levin
Date: Thu Dec 13 2018 - 14:59:28 EST


On Thu, Dec 13, 2018 at 04:35:43PM +0000, Dexuan Cui wrote:

Before 98f4c651762c, we returned zeros for unopened channels.
With 98f4c651762c, we started to return random on-stack values.

We'd better return -EINVAL instead.

Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to dev_groups")
Cc: stable@xxxxxxxxxxxxxxx
Cc: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Cc: Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>
Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

Queued up, thank you.

--
Thanks,
Sasha