Re: [PATCH] arch: arm: socfpga: arria10: Add stmmac ptp_ref clock to socdk devicetree

[Dalon Westergreen]

On Thu, 2018-12-13 at 15:56 -0600, Dinh Nguyen wrote:
> 
> On 12/13/18 2:59 PM, dwesterg@xxxxxxxxx wrote:
> > From: Dalon Westergreen <dalon.westergreen@xxxxxxxxxxxxxxx>
> > 
> > Add the stmmac ptp_ref clock as it is configured in the arria10 socdk.
> > The stmmac driver defaults the ptp_ref clock to the main stmmac clock
> > if the ptp_ref clock is not set in the devicetree.  This is inapprotiate
> 
> s/inapprotiate/inappropriate
> 
> > for the arria10 socdk.
> > 
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@xxxxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> > b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> > index 2a7466891d0e..58bfa84dcdb3 100644
> > --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> > +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> > @@ -74,7 +74,8 @@
> >  &gmac0 {
> >  	phy-mode = "rgmii";
> >  	phy-addr = <0xffffffff>; /* probe for phy addr */
> > -
> > +	clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
> > +	clock-names = "stmmaceth", "ptp_ref";
> >  	
> These should go into the base arria10 dtsi at socfpga_arria10.dtsi?
> Should the other gmacs get the same updates?

Agreed, I will send a new patch set that addresses cv/av, a10, and s10.

> 
> Also the patch header should be "ARM: dts: arria10:"
> 
> Dinh