RE: [PATCH v4] PM / devfreq: Restart previous governor if new governor fails to start

From: MyungJoo Ham
Date: Thu Dec 13 2018 - 20:45:43 EST

> From: Saravana Kannan <skannan@xxxxxxxxxxxxxx>
> If the new governor fails to start, switch back to old governor so that the
> devfreq state is not left in some weird limbo.
> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> Signed-off-by: Saravana Kannan <skannan@xxxxxxxxxxxxxx>
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>


In overall, the idea and the implementation looks good.

However, I have a question:

What if the following line fails?

+ df->governor->event_handler(df, DEVFREQ_GOV_START,
+ NULL);

Don't we still need something to handle for such events?