Re: [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt

From: Adrian Hunter
Date: Fri Dec 14 2018 - 02:37:49 EST


On 13/12/18 10:25 PM, Sowjanya Komatineni wrote:
> Some of the SDMMC pads auto calibration values parsed from
> devicetree are assigned incorrectly. This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
> drivers/mmc/host/sdhci-tegra.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7b95d088fdef..e6ace31e2a41 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-3v3-timeout",
> - &autocal->pull_up_3v3);
> + &autocal->pull_up_3v3_timeout);
> if (err)
> autocal->pull_up_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-3v3-timeout",
> - &autocal->pull_down_3v3);
> + &autocal->pull_down_3v3_timeout);
> if (err)
> autocal->pull_down_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-1v8-timeout",
> - &autocal->pull_up_1v8);
> + &autocal->pull_up_1v8_timeout);
> if (err)
> autocal->pull_up_1v8_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-1v8-timeout",
> - &autocal->pull_down_1v8);
> + &autocal->pull_down_1v8_timeout);
> if (err)
> autocal->pull_down_1v8_timeout = 0;
>
>