RE: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

[Don.Brace]

-----Original Message-----
From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Ivan Mironov
Sent: Friday, December 14, 2018 7:21 AM
To: linux-scsi@xxxxxxxxxxxxxxx; mironov.ivan@xxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx; Don Brace <don.brace@xxxxxxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; esc.storagedev@xxxxxxxxxxxxx
Subject: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

This series of patches adds support of the HBA mode on HP Smart Array P410i RAID controllers.

This is not guaranteed to be correct as I do not have any access to documentation on these controllers. However, this works fine for me on hardware that I have. Also, these changes successfully passes blktests[1] and xfstests[2].

To make sure that this new functionality does not break anything, it is disabled by default and may be enabled only manually using new module parameter.

[1] https://github.com/osandov/blktests
[2] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git

Ivan Mironov (6):
  scsi: hpsa: Add function to check if device is a disk or a zoned
    device
  scsi: hpsa: Support HBA mode on HP Smart Array P410i controllers
  scsi: hpsa: Add/mask existing devices on rescan if visibility changes
  scsi: hpsa: Ignore HBA flag from NVRAM if logical devices exist
  scsi: hpsa: Name more fields in "struct bmic_identify_controller"
  scsi: hpsa: Do not use HBA flag from NVRAM if HBA is not supported

 drivers/scsi/hpsa.c     | 145 ++++++++++++++++++++++++++++++++++++----
 drivers/scsi/hpsa.h     |   3 +
 drivers/scsi/hpsa_cmd.h | 113 ++++++++++++++++++++++++++++++-
 3 files changed, 244 insertions(+), 17 deletions(-)

--
2.19.2

NAKing this series.
- The P410 controllers do not fully support HBA mode and we do not support adding it to the hpsa driver.