Re: [PATCH] w90p910_ether: remove incorrect __init annotation

From: David Miller
Date: Fri Dec 14 2018 - 16:23:03 EST

From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Mon, 10 Dec 2018 21:45:07 +0100

> The get_mac_address() function is normally inline, but when it is
> not, we get a warning that this configuration is broken:
> WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address()
> The function w90p910_ether_setup() references
> the function __init get_mac_address().
> This is often because w90p910_ether_setup lacks a __init
> Remove the __init to make it always do the right thing.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Actually I think we can validly mark w90p910_ether_setup() and
w90p910_probe() with appropriate init tagging. None of these
functions are invoked outside of the probing paths.