Re: [PATCH net-next] tcp: minor optimization for calculating packets_out in tcp connect

[David Miller]

From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Sat, 15 Dec 2018 04:59:00 -0800

> 
> 
> On 12/15/2018 01:33 AM, Yafang Shao wrote:
>> When we building a syn packet, the tcp_skb_pcount(skb) is always 1,
>> which is set in tcp_init_nondata_skb().
>> Regarding the syn_data, it is set through
>> memcpy(syn_data->cb, syn->cb, sizeof(syn->cb)),
>> which is always 1 as well.
>> 
>> So we don't need to use tcp_skb_pcount(skb), that could give us a
>> little improvement.
>>
> 
> I dunno, I find current code more self-documented.
> 
> This is not fast path, so I would suggest we keep it.

I agree, I won't be applying this.