Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

From: Masahiro Yamada
Date: Sun Dec 16 2018 - 10:32:16 EST


On Sat, Dec 15, 2018 at 3:34 AM Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
>
> On Fri, Dec 14, 2018 at 12:06 AM Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >
> > -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden
>
> -Wstrict-prototypes (plural)
>
> > by -Werror=strict-prototype later.
>
> -Werror=strict-prototypes (plural)
>
> LGTM: https://godbolt.org/z/DyEpmU
>
> If you would mind updating the commit message (and subject), then:
> Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>


Thanks for checking this.

I will locally fix those typos (including the one in the subject).



--
Best Regards
Masahiro Yamada