Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

From: Uwe Kleine-König
Date: Mon Dec 17 2018 - 04:26:23 EST

On Mon, Dec 17, 2018 at 10:12:14AM +0100, Krzysztof HaÅasa wrote:
> 90ad2cbe88c22d0215225ab9594eeead0eb24fde changed the i.MX I2C bus driver
> to use a notifier whenever the base clock ("ipg" - 66 MHz peripheral
> clock) rate changes.
> Unfortunately one can't use the container_of() macro this way - the
> first argument has to point to a member of the bigger struct (last
> argument). Merely pointing to the same value isn't enough (the clk
> variable which has its address passed to the macro is the clk in
> notifier_block, not the one in imx_i2c_struct, even though both pointers
> point to the same clk struct).
> This bug causes kernel panic when the IPG clock rate changes (e.g. if
> any clock derived from IPG changes).
> Signed-off-by: Krzysztof Halasa <khalasa@xxxxxxx>

I didn't look at the patch, but I suggest a Fixes: line here à la:

Fixes: 90ad2cbe88c2 ("i2c: imx: use clk notifier for rate changes")

Best regards

Pengutronix e.K. | Uwe Kleine-KÃnig |
Industrial Linux Solutions | |