Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

From: Rafael J. Wysocki
Date: Mon Dec 17 2018 - 06:46:21 EST


On Tuesday, December 11, 2018 7:53:05 PM CET Kevin Hilman wrote:
> Thomas Meyer <thomas@xxxxxxxx> writes:
>
> > NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
>
> Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
>
> > ---
> >
> > diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
> >
> > if (sr_info->autocomp_active)
> > sr_stop_vddautocomp(sr_info);
> > - if (sr_info->dbg_dir)
> > - debugfs_remove_recursive(sr_info->dbg_dir);
> > + debugfs_remove_recursive(sr_info->dbg_dir);
> >
> > pm_runtime_disable(&pdev->dev);
> > list_del(&sr_info->node);
>

Patch applied, thanks!