Re: [RFC/RFT][PATCH v8] cpuidle: New timer events oriented governor for tickless systems
From: Rafael J. Wysocki
Date: Mon Dec 17 2018 - 07:00:03 EST
On Mon, Dec 17, 2018 at 2:53 AM Doug Smythies <dsmythies@xxxxxxxxx> wrote:
> On 2018.12.11 03:50 Rafael J. Wysocki wrote:
> > With this version of the TEO governor I'm observing slight, but consistent
> > performance improvements in some different benchmarks on a few different
> > systems with respect to menu
> Same here.
> > and the corresponding power draw differences
> > appear to be in the noise. The idle power doesn't seem to change either.
> Same here.
> > Also the "above" and "below" metrics (introduced by a separate patch under
> > discussion) indicate changes in the "good" direction.
> My graphs now include the "above" and "below" metrics.
> In particular see Idle State 1 "above" (was too deep) graphs in the links below.
> However, performance is up and power about the same, so O.K.
Thanks a lot for the comprehensive results, much appreciated as always!
This basically confirms my own observations, so my overall conclusion
is that what we have here is as good as it can get without changing
the approach entirely or adding complications that would be difficult
to justify in general.
> > Overall, I like this one, so I may consider dropping the RFC/RFT tag from the
> > next submission. :-)
And so that's what I'm going to do.