Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe()

From: Lee Jones
Date: Mon Dec 17 2018 - 09:34:42 EST


On Mon, 17 Dec 2018, J, KEERTHY wrote:

>
>
> On 12/14/2018 5:56 PM, Lee Jones wrote:
> > On Fri, 14 Dec 2018, Lee Jones wrote:
> >
> > > On Thu, 06 Dec 2018, Christian Hohnstaedt wrote:
> > >
> > > > Free allocated IRQ if reading the device ID fails.
> > >
> > > The patch is fine. However, in future please submit patches using the
> > > format set (by precedent) by the subsystem. I will fix the subject
> > > for you this time.
> > >
> > > To check the format, you can do:
> > >
> > > `git log --oneline -- <subsystem>`
> >
> > Patch applied, by the way.
>
> This would no longer be needed as the bigger clean up is here:
>
> https://lkml.org/lkml/2018/12/9/86
>
> As both are applied it results in a compilation issue.
>
> Lee Jones,
>
> Do you want me to submit a fix patch? Or you can revert this patch?
> Anything fine by me.

I have removed this patch from the MFD tree now. Thanks.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog