[PATCH v2 05/19] mailbox: bcm-pdc: Use device-managed registration API
From: Thierry Reding
Date: Mon Dec 17 2018 - 10:02:37 EST
From: Thierry Reding <treding@xxxxxxxxxx>
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.
Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
Cc: Steve Lin <steven.lin1@xxxxxxxxxxxx>
Cc: Jon Mason <jon.mason@xxxxxxxxxxxx>
Cc: Rob Rice <rob.rice@xxxxxxxxxxxx>
Cc: Andy Gospodarek <gospo@xxxxxxxxxxxx>
Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
---
drivers/mailbox/bcm-pdc-mailbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/bcm-pdc-mailbox.c b/drivers/mailbox/bcm-pdc-mailbox.c
index 4fe7be0bdd11..ccf3d62af7e7 100644
--- a/drivers/mailbox/bcm-pdc-mailbox.c
+++ b/drivers/mailbox/bcm-pdc-mailbox.c
@@ -1471,7 +1471,7 @@ static int pdc_mb_init(struct pdc_state *pdcs)
mbc->chans[chan_index].con_priv = pdcs;
/* Register mailbox controller */
- err = mbox_controller_register(mbc);
+ err = devm_mbox_controller_register(dev, mbc);
if (err) {
dev_crit(dev,
"Failed to register PDC mailbox controller. Error %d.",
@@ -1641,8 +1641,6 @@ static int pdc_remove(struct platform_device *pdev)
pdc_hw_disable(pdcs);
- mbox_controller_unregister(&pdcs->mbc);
-
dma_pool_destroy(pdcs->rx_buf_pool);
dma_pool_destroy(pdcs->ring_pool);
return 0;
--
2.19.1