Re: [PATCH] kbuild: error for CONFIG_ORC_UNWINDER is too much
From: Josh Poimboeuf
Date: Mon Dec 17 2018 - 12:03:12 EST
On Mon, Dec 17, 2018 at 11:17:28AM -0500, Qian Cai wrote:
> Since ifdef will be evaluated immediately in the first phrase of the
> Makefile read-in, there is no guarantee that the value for
> CONFIG_ORC_UNWINDER will be up-to-date until in the second phrase that
> this recipe is ran.
>
> include/config/%.conf: $(KCONFIG_CONFIG) include/config/auto.conf.cmd
> $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
>
> Hence, change error to warning as this is essentially a best guess. The
> original bug can be reproduced this way,
But this still doesn't fix the root of the problem, that the check
relies on a stale auto.conf.
--
Josh