Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

From: Joe Perches
Date: Mon Dec 17 2018 - 12:21:37 EST


On Mon, 2018-12-17 at 21:49 +0530, Amit Kucheria wrote:
> Several drivers didn't have a specific maintainer (other than the
> subsystem maintainer). Switch to using the 'qcom' and 'msm' regex
> patterns to capture all of them and add exceptions to the couple of
> drivers that contain 'msm' but are not related to qcom hardware.
>
> Thanks to Marc for the idea to use the N regex.
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -1929,20 +1929,14 @@ M: Andy Gross <andy.gross@xxxxxxxxxx>
> M: David Brown <david.brown@xxxxxxxxxx>
> L: linux-arm-msm@xxxxxxxxxxxxxxx
> S: Maintained
> -F: Documentation/devicetree/bindings/soc/qcom/
> -F: arch/arm/boot/dts/qcom-*.dts
> -F: arch/arm/boot/dts/qcom-*.dtsi
> -F: arch/arm/mach-qcom/
> -F: arch/arm64/boot/dts/qcom/*
> +N: qcom
> +N: msm

It is generally better to use a comprehensive list of F: patterns
over N: patterns as N: patterns are not used as properly maintained
entries for files matched by the get_maintainer.pl script.

git history is used by default for the N: entries and that can
cause whitespace style commit authors to be cc'd on various changes
to matched files.

Also msm is a pretty common filename pattern and the X: exclusions
for various matching but not associated files might need to be added
to quite often.

>From MAINTAINERS:

N: Files and directories with regex patterns.
N: [^a-z]tegra all files whose path contains the word tegra
One pattern per line. Multiple N: lines acceptable.
scripts/get_maintainer.pl has different behavior for files that
match F: pattern and matches of N: patterns. By default,
get_maintainer will not look at git log history when an F: pattern
match occurs. When an N: match occurs, git log history is used
to also notify the people that have git commit signatures.