Re: [RFC] regmap-irq: add "main register" and level-irq support

From: Mark Brown
Date: Mon Dec 17 2018 - 13:50:23 EST


On Mon, Dec 17, 2018 at 10:19:12AM +0200, Matti Vaittinen wrote:
> On Fri, Dec 14, 2018 at 05:26:19PM +0000, Mark Brown wrote:
> > On Fri, Dec 14, 2018 at 03:58:19PM +0200, Matti Vaittinen wrote:
> > > On Fri, Dec 07, 2018 at 01:14:18PM +0000, Mark Brown wrote:

> > > I could send an example on how the driver utilizing the original RFC
> > > interface would look like. I am starting to think it was not *that* bad
> > > after all...

> > That might help, yes.

> This is what I came up with. I think having the simple mapping arrays
> (bitX_offsets) and REGMAP_IRQ_MAIN_REG_OFFSET macro makes this
> not-so-bad :) I will also send an example on how this would look like
> with the RFC v2 interface.

I think your approach is fine - there's not much difference really.

Attachment: signature.asc
Description: PGP signature