Re: objtool warnings for kernel/trace/trace_selftest_dynamic.o

From: Peter Zijlstra
Date: Mon Dec 17 2018 - 14:29:51 EST

On Mon, Dec 17, 2018 at 12:16:38PM -0600, Josh Poimboeuf wrote:

> > Yes LTO causes the to be treated like static functions.
> >
> > I guess noclone is unlikely to be really needed here because these
> > functions are unlikely to be cloned.
> >
> > So as a workaround it could be removed.
> >
> > But note we have other noclone functions in the tree (like in KVM)
> > which actually need it.
> How about we just use the __used attribute then? It seems to have the
> same result of preventing IPA optimizations (without the weird side
> effect of missing frame pointers).

AFAIK we don't have any in-tree LTO, so it can all go in the bin.

When/if we get the LTO trainwreck sorted -- which very much includes
getting that memory-order-consume fixed -- we can revisit all that.