Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

From: Qii Wang
Date: Mon Dec 17 2018 - 21:35:38 EST


On Tue, 2018-12-18 at 00:06 +0100, Wolfram Sang wrote:
> > > What is "multi-user"? Why can't you add this offset to the reg-property
> > > directly?
>
> ...
>
> > MT8183 doesn't need to support muti-user according to the latest project
> > information, and I'll remove this feature from patches.
>
> Okay. It will be dropped then, thanks for the heads up!
>
> > > > + - mediatek,share-i3c: i3c controller can share i2c function.
> > >
> > > Please explain in more detail? Is this an I3C controller?
> >
> > Yes, it is a i3c controller, and it is compatible with i2c. I only use
> > the feature of i2c, so I need a flag to do some extra settings.
>
> Can't you derive this from the compatible? If it is
> "mediatek,mt8183-i2c", then you know you need these extra settings?
>

Not all channels are i3c controllers in MT8183. only i3c controller need
some extra settings.