Re: [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node

From: Sibi Sankar
Date: Tue Dec 18 2018 - 01:35:13 EST

Hi Doug,
Thanks for the review :)

On 2018-12-18 05:32, Doug Anderson wrote:

On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar <sibis@xxxxxxxxxxxxxx> wrote:

This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs.

Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>

* Fixed style changes
* Added missing clocks in the dt-bindings
* Split mss remoteproc node into a number of patches

I know there was some off-list suggestion to split this into a number
of patches, but to actually make that useful to anyone we'd actually
need to _also_ post up patches to make the driver probe / work without
these power domains. ...and as per other discussions it's kinda
"lucky" that it happens to work without them and Bjorn wasn't
supportive of making this optional.

So I'd actually fold patch 6 into patch 5 and focus on getting the
"aoss_qmp_pd" landed sooner rather than later.

I'll fold them in v3

Keeping the "shutdown-ack" as a separate patch makes sense though
since the bindings currently list that as "optional" and I guess
things work OK w/out it.

Once patch #6 is folded into patch #5 feel free to add my Reviewed-by tag.


-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.