Re: [PATCH v2] drbd: Avoid Clang warning about pointless switch statment
From: Lars Ellenberg
Date: Tue Dec 18 2018 - 04:22:11 EST
On Mon, Dec 17, 2018 at 10:29:38AM -0700, Jens Axboe wrote:
> > Hi Lars and Philipp,
> > Could you please make sure that this patch and the other one I sent make
> > it into 4.21/5.0? I am not sure when you were planning on sending the
> > pull request to Jens that you mentioned in the other thread but I've
> > noticed most maintainers typically send their requests for the impending
> > merge window around -rc7 or so and I wanted to make sure it was on your
> > radar.
>From my point of view, "fixing the pointless switch" is just "pointless",
so it (again) fell through. I get it that it is important to others,
and getting rid of Clang warnings is a good thing. So sorry again.
> It needs to get here now, but drbd hasn't really sent anything in for
> about a year,
Last actual fix was 2018-06-25 64dafbc9530c drbd: fix access after free
so almost six month, yes.
> so I'm starting to doubt how maintained it is at this
Oh, it is maintained. It is just happens to be "stable".
We don't add new features there,
and I'm currently not aware of any misbehavior.
I'll prepare a pull request containing this,
the other Clang warning patch from Nathan,
and possibly other small stuff that accumulated,
if I can find any, and send that out later today.
Thanks for the reminder,