Re: [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible

From: Marc Zyngier
Date: Tue Dec 18 2018 - 07:59:48 EST


On 17/12/2018 15:51, Lucas Stach wrote:
> Hi Marc,
>
> Am Freitag, den 14.12.2018, 13:15 +0100 schrieb Lucas Stach:
>> The GPC node on i.MX8MQ can not claim to be compatible with the i.MX7D
>> GPC, as the power gating part has some significant differences. Thus we
>> can not rely on the irqchip being probed with the old compatible.
>>
>>> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> ---
>> Âdrivers/irqchip/irq-imx-gpcv2.c | 3 ++-
>> Â1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
>> index 17a2dad2d4c2..68b9cca24044 100644
>> --- a/drivers/irqchip/irq-imx-gpcv2.c
>> +++ b/drivers/irqchip/irq-imx-gpcv2.c
>> @@ -289,4 +289,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>>> Â return 0;
>> Â}
>> Â
>> -IRQCHIP_DECLARE(imx_gpcv2, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
>> +IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
>> +IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);
>
> It would be nice if we could get this into 4.21, as this is the last
> missing bit preventing me from pushing forward on the patches
> describing the i.MX8MQ IRQ hierarchy properly for the next cycle.

Now applied.

Thanks,

M.
--
Jazz is not dead. It just smells funny...