Re: [PATCH v4 1/2] export trace.c helper functions to other modules

From: Christoph Hellwig
Date: Tue Dec 18 2018 - 11:57:09 EST

On Mon, Dec 17, 2018 at 08:51:37PM -0800, yupeng wrote:
> Export bellow three functions:
> nvme_trace_parse_admin_cmd
> nvme_trace_parse_nvm_cmd
> nvme_trace_disk_name
> Thus any other modules which depends on nvme-core could use the trace
> events in trace.h

But we don't actually use these trace events anywhere outside of core.c,
even with your second patch, do we?