Re: [PATCH v2] mm, page_alloc: Fix has_unmovable_pages for HugePages

From: Oscar Salvador
Date: Tue Dec 18 2018 - 16:51:29 EST


On Mon, Dec 17, 2018 at 03:07:26PM -0800, Andrew Morton wrote:
> On Mon, 17 Dec 2018 23:51:13 +0100 Oscar Salvador <osalvador@xxxxxxx> wrote:
>
> > v1 -> v2:
> > - Fix the logic for skipping pages by Michal
> >
> > ---
>
> Please be careful with the "^---$". It signifies end-of-changelog, so
> I ended up without a changelog!

Sorry Andrew, somehow I screwed it up!
I will be more careful next time.

>
> > >From e346b151037d3c37feb10a981a4d2a25018acf81 Mon Sep 17 00:00:00 2001
> > From: Oscar Salvador <osalvador@xxxxxxx>
> > Date: Mon, 17 Dec 2018 14:53:35 +0100
> > Subject: [PATCH] mm, page_alloc: Fix has_unmovable_pages for HugePages
> >
> > While playing with gigantic hugepages and memory_hotplug, I triggered
> > the following #PF when "cat memoryX/removable":
> >
> > ...
> >
> > Also, since gigantic pages span several pageblocks, re-adjust the logic
> > for skipping pages.
> >
> > Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
>
> cc:stable?
>

--
Oscar Salvador
SUSE L3