Re: [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters

From: Wolfram Sang
Date: Tue Dec 18 2018 - 18:33:59 EST



> > + unsigned int is_suspended:1; /* owned by the I2C core */
>
> When more stuff is added to this bit field (which always happens at
> some point) updates to all members of the bit field will have to use
> the same root-adapter-locking, or we will suffer from RMW-races. So
> this feels like an invitation for future disaster. Maybe a comment
> about that to remind our future selves? Or perhaps the bit field
> should be avoided altogether?

Changed to bool. Thanks!

Attachment: signature.asc
Description: PGP signature