Re: [PATCH v3 7/8] HID: logitech: Enable high-resolution scrolling on Logitech mice

[Benjamin Tissoires]

On Wed, Dec 19, 2018 at 11:57 AM ClÃment VUCHENER
<clement.vuchener@xxxxxxxxx> wrote:
>
> Le sam. 15 dÃc. 2018 Ã 15:45, ClÃment VUCHENER
> <clement.vuchener@xxxxxxxxx> a Ãcrit :
> >
> > Le ven. 14 dÃc. 2018 Ã 19:37, Harry Cutts <hcutts@xxxxxxxxxxxx> a Ãcrit :
> > >
> > > Hi Clement,
> > >
> > > On Fri, 14 Dec 2018 at 05:47, ClÃment VUCHENER
> > > <clement.vuchener@xxxxxxxxx> wrote:
> > > > Hi, The G500s (and the G500 too, I think) does support the "scrolling
> > > > acceleration" bit. If I set it, I get around 8 events for each wheel
> > > > "click", this is what this driver expects, right? If I understood
> > > > correctly, I should try this patch with the
> > > > HIDPP_QUIRK_HI_RES_SCROLL_1P0 quirk set for my mouse.
> > >
> > > Thanks for the info! Yes, that should work.
> >
> > Well, it is not that simple. I get "Device not connected" errors for
> > both interfaces of the mouse.
>
> I suspect the device is not responding because the hid device is not
> started. When is hid_hw_start supposed to be called? It is called
> early for HID_QUIRK_CLASS_G920 but later for other device. So the
> device is not started when hidpp_is_connected is called. Is this
> because most of the device in this driver are not real HID devices but
> DJ devices? How should non-DJ devices be treated?

Hi Clement,

I have a series I sent last September that allows to support non DJ
devices on logitech-hidpp
(https://patchwork.kernel.org/project/linux-input/list/?series=16359).

In its current form, with the latest upstream kernel, the series will
oops during the .event() callback, which is easy enough to fix.
However, I am currently trying to make it better as a second or third
reading made me realized that there was a bunch of non-sense in it and
a proper support would require slightly more work for the non unifying
receiver case.

I hope I'll be able to send out something by the end of the week.

Cheers,
Benjamin