Re: [PATCH 1/2] ARC: show_regs: avoid page allocator
From: Vineet Gupta
Date: Wed Dec 19 2018 - 16:36:56 EST
On 12/19/18 12:46 PM, William Kucharski wrote:
> I would rather see 256 as a #define somewhere rather than a magic number sprinkled
> around arch/arc/kernel/troubleshoot.c.
That bothered me as well, but I was too lazy to define one and the existing ones
don't apply. PATH_MAX is 4K which will blow up the stack usage.
>
> Still, that's what the existing code does, so I suppose it's OK.
I'll define one locally.
> Otherwise the change looks good.
Thx for taking a look.
> Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>
I'll add this to the patch.
Thx,
-Vineet