Re: [PATCH 27/41] scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs

[Gustavo A. R. Silva]

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, I replaced "Drop thru" with
> "fall through" annotations, which is what GCC is expecting to find.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
>   drivers/scsi/lpfc/lpfc_scsi.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index baed2b891efb..0eeed6c4c2ee 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -1427,7 +1427,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
>   
>   					break;
>   				}
> -				/* Drop thru */
> +				/* fall through */
>   			case SCSI_PROT_WRITE_INSERT:
>   				/*
>   				 * For WRITE_INSERT, force the error
> @@ -1546,7 +1546,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
>   					rc = BG_ERR_TGT | BG_ERR_CHECK;
>   					break;
>   				}
> -				/* Drop thru */
> +				/* fall through */
>   			case SCSI_PROT_WRITE_INSERT:
>   				/*
>   				 * For WRITE_INSERT, force the
> @@ -1628,7 +1628,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
>   			switch (op) {
>   			case SCSI_PROT_WRITE_PASS:
>   				rc = BG_ERR_CHECK;
> -				/* Drop thru */
> +				/* fall through */
>   
>   			case SCSI_PROT_WRITE_INSERT:
>   				/*
> @@ -4115,7 +4115,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
>   					lpfc_cmd->cur_iocbq.sli4_lxritag,
>   					0, 0);
>   			}
> -		/* else: fall through */
> +			/* fall through */
>   		default:
>   			cmd->result = DID_ERROR << 16;
>   			break;