Re: [PATCH v2 4/7] drm: sti: Cleanup drm_display_mode print str

[Benjamin Gaignard]

Le jeu. 20 dÃc. 2018 Ã 13:27, Shayenne Moura
<shayenneluzmoura@xxxxxxxxx> a Ãcrit :
>
> This patch adjust the print string of drm_display_mode object
> to remove drm_mode_object dependency in sti files.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@xxxxxxxxx>

Acked-by: Benjamin Gaignard <benjamin;gaignard@xxxxxxxxxx>

>
> ---
> Changes in v2:
>   - Use DRM_MODE_FMT/ARG macros (Daniel)
>   - Make the commit message more clear
>
>  drivers/gpu/drm/sti/sti_crtc.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index ed76e52eb213..ec9f87483e39 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -53,18 +53,10 @@ sti_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode)
>         struct clk *compo_clk, *pix_clk;
>         int rate = mode->clock * 1000;
>
> -       DRM_DEBUG_KMS("CRTC:%d (%s) mode:%d (%s)\n",
> -                     crtc->base.id, sti_mixer_to_str(mixer),
> -                     mode->base.id, mode->name);
> -
> -       DRM_DEBUG_KMS("%d %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
> -                     mode->vrefresh, mode->clock,
> -                     mode->hdisplay,
> -                     mode->hsync_start, mode->hsync_end,
> -                     mode->htotal,
> -                     mode->vdisplay,
> -                     mode->vsync_start, mode->vsync_end,
> -                     mode->vtotal, mode->type, mode->flags);
> +       DRM_DEBUG_KMS("CRTC:%d (%s) mode: (%s)\n",
> +                     crtc->base.id, sti_mixer_to_str(mixer), mode->name);
> +
> +       DRM_DEBUG_KMS(DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
>
>         if (mixer->id == STI_MIXER_MAIN) {
>                 compo_clk = compo->clk_compo_main;
> --
> 2.17.1
>


-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog