Re: [PATCH] ACPI/APEI: Clear GHES block_status before panic()

From: Tyler Baicar
Date: Thu Dec 20 2018 - 13:28:56 EST


On Wed, Dec 19, 2018 at 1:33 PM David Arcari <darcari@xxxxxxxxxx> wrote:
>
> From: Lenny Szubowicz <lszubowi@xxxxxxxxxx>
>
> In __ghes_panic() clear the block status in the APEI generic
> error status block for that generic hardware error source before
> calling panic() to prevent a second panic() in the crash kernel
> for exactly the same fatal error.
>
> Otherwise ghes_probe(), running in the crash kernel, would see
> an unhandled error in the APEI generic error status block and
> panic again, thereby precluding any crash dump.
>
> Signed-off-by: Lenny Szubowicz <lszubowi@xxxxxxxxxx>
> Signed-off-by: David Arcari <darcari@xxxxxxxxxx>

Good catch!

Tested-by: Tyler Baicar <baicar.tyler@xxxxxxxxx>