Re: [PATCH v2] arm64: dts: sdm845: Add PSCI cpuidle low power states

[Lina Iyer]

On Thu, Dec 20 2018 at 14:42 -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Nov 30, 2018 at 7:41 AM Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote:
> > On Tue, Oct 30 2018 at 11:23 -0600, Raju P.L.S.S.S.N wrote:
> > >Add device bindings for cpuidle states for cpu devices.
> > >
> > >Cc: <devicetree@xxxxxxxxxxxxxxx>
> > >Signed-off-by: Raju P.L.S.S.S.N <rplsssn@xxxxxxxxxxxxxx>
> > >---
> > >Changes in v2
> > > - Address comments from Doug
> > >---
> > >---
> > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 62 ++++++++++++++++++++++++++++++++++++
> > > 1 file changed, 62 insertions(+)
> > >
> > >diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > >index 0c9a2aa..3a8381e 100644
> > >--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > >+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > >@@ -96,6 +96,7 @@
> > >                       reg = <0x0 0x0>;
> > >                       enable-method = "psci";
> > >                       next-level-cache = <&L2_0>;
> > >+                      cpu-idle-states = <&C0_CPU_PD &C0_CPU_RPD &CLUSTER_PD>;
> > I think it might be better to use
> > <&C0_CPU_PD>, <&C0_CPU_RPD>, <&CLUSTER_PD>
>
> I disagree.  All existing examples in both bindings and other device
> trees use the syntax that Raju uses.  It doesn't matter
> functionality-wise, but I'd much rather match everyone else.  We
> should land what Raju has posted and if someone feels super strongly
> that the examples in the bindings are wrong then they should attempt
> to convince Rob Herring to Ack a change to the examples in the
> bindings.  Doesn't seem like a good use of time to me, though.
No strong preference from my end.

-- Lina